-
Notifications
You must be signed in to change notification settings - Fork 1
chore(deps): update dependency vite to v7 [security] #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
renovate
wants to merge
1
commit into
main
Choose a base branch
from
renovate/npm-vite-vulnerability
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0da8de8
to
9b48dfa
Compare
9b48dfa
to
d897cbd
Compare
d897cbd
to
1eafdda
Compare
1eafdda
to
39d9273
Compare
39d9273
to
07a1453
Compare
07a1453
to
92c2556
Compare
92c2556
to
1511c9e
Compare
1511c9e
to
a5ab4ca
Compare
a5ab4ca
to
c8af7cb
Compare
c8af7cb
to
ae3eb9c
Compare
ae3eb9c
to
82ffc9b
Compare
82ffc9b
to
5580fbf
Compare
5580fbf
to
124dd91
Compare
124dd91
to
7489490
Compare
7489490
to
8e4ea0a
Compare
c5f1e37
to
5b9d265
Compare
5b9d265
to
3d64c63
Compare
3d64c63
to
fcd12bf
Compare
fcd12bf
to
771e5b5
Compare
771e5b5
to
aff1be9
Compare
aff1be9
to
3f83a73
Compare
3f83a73
to
b745a9f
Compare
b745a9f
to
032bcd5
Compare
032bcd5
to
3353e7f
Compare
3353e7f
to
eabfa87
Compare
eabfa87
to
4d26b5a
Compare
4d26b5a
to
2e2fd90
Compare
2e2fd90
to
ad06ad3
Compare
ad06ad3
to
e6781b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
0 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^3.2.8
->^7.0.0
GitHub Vulnerability Alerts
CVE-2025-24010
Summary
Vite allowed any websites to send any requests to the development server and read the response due to default CORS settings and lack of validation on the Origin header for WebSocket connections.
Warning
This vulnerability even applies to users that only run the Vite dev server on the local machine and does not expose the dev server to the network.
Upgrade Path
Users that does not match either of the following conditions should be able to upgrade to a newer version of Vite that fixes the vulnerability without any additional configuration.
localhost
or*.localhost
Using the backend integration feature
If you are using the backend integration feature and not setting
server.origin
, you need to add the origin of the backend server to theserver.cors.origin
option. Make sure to set a specific origin rather than*
, otherwise any origin can access your development server.Using a reverse proxy in front of Vite
If you are using a reverse proxy in front of Vite and sending requests to Vite with a hostname other than
localhost
or*.localhost
, you need to add the hostname to the newserver.allowedHosts
option. For example, if the reverse proxy is sending requests tohttp://vite:5173
, you need to addvite
to theserver.allowedHosts
option.Accessing the development server via a domain other than
localhost
or*.localhost
You need to add the hostname to the new
server.allowedHosts
option. For example, if you are accessing the development server viahttp://foo.example.com:8080
, you need to addfoo.example.com
to theserver.allowedHosts
option.Using a plugin / framework that connects to the WebSocket server on their own from the browser
If you are using a plugin / framework, try upgrading to a newer version of Vite that fixes the vulnerability. If the WebSocket connection appears not to be working, the plugin / framework may have a code that connects to the WebSocket server on their own from the browser.
In that case, you can either:
legacy.skipWebSocketTokenCheck: true
to opt-out the fix for [2] while the plugin / framework is incompatible with the new version of ViteMitigation without upgrading Vite
[1]: Permissive default CORS settings
Set
server.cors
tofalse
or limitserver.cors.origin
to trusted origins.[2]: Lack of validation on the Origin header for WebSocket connections
There aren't any mitigations for this.
[3]: Lack of validation on the Host header for HTTP requests
Use Chrome 94+ or use HTTPS for the development server.
Details
There are three causes that allowed malicious websites to send any requests to the development server:
[1]: Permissive default CORS settings
Vite sets the
Access-Control-Allow-Origin
header depending onserver.cors
option. The default value wastrue
which setsAccess-Control-Allow-Origin: *
. This allows websites on any origin tofetch
contents served on the development server.Attack scenario:
http://malicious.example.com
).fetch('http://127.0.0.1:5173/main.js')
request by JS in that malicious web page. This request is normally blocked by same-origin policy, but that's not the case for the reasons above.http://127.0.0.1:5173/main.js
.[2]: Lack of validation on the Origin header for WebSocket connections
Vite starts a WebSocket server to handle HMR and other functionalities. This WebSocket server did not perform validation on the Origin header and was vulnerable to Cross-Site WebSocket Hijacking (CSWSH) attacks. With that attack, an attacker can read and write messages on the WebSocket connection. Vite only sends some information over the WebSocket connection (list of the file paths that changed, the file content where the errored happened, etc.), but plugins can send arbitrary messages and may include more sensitive information.
Attack scenario:
http://malicious.example.com
).new WebSocket('http://127.0.0.1:5173', 'vite-hmr')
by JS in that malicious web page.[3]: Lack of validation on the Host header for HTTP requests
Unless
server.https
is set, Vite starts the development server on HTTP. Non-HTTPS servers are vulnerable to DNS rebinding attacks without validation on the Host header. But Vite did not perform validation on the Host header. By exploiting this vulnerability, an attacker can send arbitrary requests to the development server bypassing the same-origin policy.http://malicious.example.com:5173
) (HTTPS won't work).fetch('/main.js')
request by JS in that malicious web page.http://127.0.0.1:5173/main.js
bypassing the same origin policy.Impact
[1]: Permissive default CORS settings
Users with the default
server.cors
option may:server.proxy
may have those functionalities.[2]: Lack of validation on the Origin header for WebSocket connections
All users may get the file paths of the files that changed and the file content where the error happened be stolen by malicious websites.
For users that is using a plugin that sends messages over WebSocket, that content may be stolen by malicious websites.
For users that is using a plugin that has a functionality that is triggered by messages over WebSocket, that functionality may be exploited by malicious websites.
[3]: Lack of validation on the Host header for HTTP requests
Users using HTTP for the development server and using a browser that is not Chrome 94+ may:
server.proxy
may have those functionalities.Chrome 94+ users are not affected for [3], because sending a request to a private network page from public non-HTTPS page is forbidden since Chrome 94.
Related Information
Safari has a bug that blocks requests to loopback addresses from HTTPS origins. This means when the user is using Safari and Vite is listening on lookback addresses, there's another condition of "the malicious web page is served on HTTP" to make [1] and [2] to work.
PoC
[2]: Lack of validation on the Origin header for WebSocket connections
react
template which utilizes HMR functionality.http://localhost:5173/
) as well as the malicious page in the browser.src/App.jsx
file and intentionally place a syntax errorHere's a video demonstrating the POC:
vite-cswsh.mov
Release Notes
vitejs/vite (vite)
v7.0.4
Compare Source
Bug Fixes
Build System
@oxc-project/runtime
devDep (#20389) (5e29602)v7.0.3
Compare Source
Bug Fixes
Miscellaneous Chores
n/prefer-node-protocol
rule (#20368) (38bb268)Code Refactoring
v7.0.2
Compare Source
Bug Fixes
v7.0.1
Compare Source
Bug Fixes
Miscellaneous Chores
v7.0.0
Compare Source
import.meta.url
in bundled Vite (#20235) (3bf3a8a), closes #20235ssrExportNameKey
(#20266) (ac302a7), closes #20266normalizeModuleId
(#20277) (9b98dcb), closes #20277numberToPos
(#20244) (3f46901), closes #20244v6.3.5
Compare Source
v6.3.4
Compare Source
require
to import externals in optimized dependenci (efc5eab), closes #19940v6.3.3
Compare Source
ssrTransform
re-export deps and test stacktrace with first line (#19629) (9399cda), closes #19629v6.3.2
Compare Source
css.lightningcss
option in css minification process (#19879) (b5055e0), closes #19879v6.3.1
Compare Source
Promise.allSettled
in preload function (#19805) (35c7f35), closes #19805transform
calls (#19878) (a152b7c), closes #19878v6.3.0
Compare Source
hot.invalidate
in circular deps (#19870) (d4ee5e8), closes #19870v6.2.7
Compare Source
Please refer to CHANGELOG.md for details.
v6.2.6
Compare Source
Please refer to CHANGELOG.md for details.
v6.2.5
Compare Source
Please refer to CHANGELOG.md for details.
v6.2.4
Compare Source
Please refer to CHANGELOG.md for details.
v6.2.3
Compare Source
Please refer to CHANGELOG.md for details.
v6.2.2
Compare Source
base
(#19616) (2476391), closes #19616v6.2.1
Compare Source
isBuild
check from preAliasPlugin (#19587) (c9e086d), closes #19587applyToEnvironment
in internal plugins (#19588) (f678442), closes #19588*?url&no-inline
type and warning for.json?inline
/.json?no-inline
(#19566) (c0d3667), closes #19566v6.2.0
Compare Source
v6.1.6
Compare Source
Please refer to CHANGELOG.md for details.
v6.1.5
Compare Source
Please refer to CHANGELOG.md for details.
v6.1.4
Compare Source
Please refer to CHANGELOG.md for details.
v6.1.3
Compare Source
Please refer to CHANGELOG.md for details.
v6.1.2
Compare Source
Please refer to CHANGELOG.md for details.
v6.1.1
Compare Source
.[cm]?[tj]sx?
static assets are JS mime (#19453) (e7ba55e), closes #19453*.ipv4
address in cert (#19416) (973283b), closes #19416v6.1.0
Compare Source
Features
port
in the logged error message after failed WS connection withEADDRINUSE
(#19212) (14027b0), closes #19212.jxl
(#18855) (57b397c), closes #18855builtins
environmentresolve
(#18584) (2c2d521), closes #18584defaultAllowedOrigins
for user-land config and 3rd party plugins (#19259) (dc8946b), closes #19259wasm
to the compressible assets regex (#19085) (ce84142), closes #19085Fixes
resolveLibCssFilename
(#19324) (f183bdf), closes #19324vite optimize
(#19347) (19ffad0), closes #19347server.preTransformRequests
(#19272) (12aaa58), closes #19272nodeLikeBuiltins
forssr.target: 'webworker'
withoutnoExternal: true
(#19313) (9fc31b6), closes #19313@plugin
imports of JS files treated as CSS and rebased (fix #19268) (#19269) (602b373), closes #19268 #19269resolve.builtin
is empty (#19312) (b7aba0b), closes #19312ssrLoadModule
(#19290) (353c467), closes #19290--force
work for all environments (#18901) (51a42c6), closes #18901RegExp
values withnew RegExp
instead ofstructuredClone
(fix #19245, fix #1 (56ad2be), closes #19245 #18875 #19247Chore
vite optimize
command (#19348) (6e0e3c0), closes #19348build.manifest
jsdocs (#19332) (4583781), closes #19332scanImports
not being used in ssr (#19285) (fbbc6da), closes #19285Beta Changelogs
6.1.0-beta.2 (2025-02-04)
See 6.1.0-beta.2 changelog
6.1.0-beta.1 (2025-02-04)
See 6.1.0-beta.1 changelog
6.1.0-beta.0 (2025-01-24)
See 6.1.0-beta.0 changelog
v6.0.15
Compare Source
Please refer to CHANGELOG.md for details.
v6.0.14
Compare Source
Please refer to CHANGELOG.md for details.
v6.0.13
Compare Source
Please refer to CHANGELOG.md for details.
v6.0.12
Compare Source
Please refer to CHANGELOG.md for details.
v6.0.11
Compare Source
preview.allowedHosts
with specific values was not respected (#19246) (aeb3ec8), closes #19246Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.