Skip to content

chore(deps): update dependency vite to v7 [security] #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 23, 2025

This PR contains the following updates:

Package Change Age Confidence
vite (source) ^3.2.8 -> ^7.0.0 age confidence

GitHub Vulnerability Alerts

CVE-2025-24010

Summary

Vite allowed any websites to send any requests to the development server and read the response due to default CORS settings and lack of validation on the Origin header for WebSocket connections.

Warning

This vulnerability even applies to users that only run the Vite dev server on the local machine and does not expose the dev server to the network.

Upgrade Path

Users that does not match either of the following conditions should be able to upgrade to a newer version of Vite that fixes the vulnerability without any additional configuration.

  • Using the backend integration feature
  • Using a reverse proxy in front of Vite
  • Accessing the development server via a domain other than localhost or *.localhost
  • Using a plugin / framework that connects to the WebSocket server on their own from the browser

Using the backend integration feature

If you are using the backend integration feature and not setting server.origin, you need to add the origin of the backend server to the server.cors.origin option. Make sure to set a specific origin rather than *, otherwise any origin can access your development server.

Using a reverse proxy in front of Vite

If you are using a reverse proxy in front of Vite and sending requests to Vite with a hostname other than localhost or *.localhost, you need to add the hostname to the new server.allowedHosts option. For example, if the reverse proxy is sending requests to http://vite:5173, you need to add vite to the server.allowedHosts option.

Accessing the development server via a domain other than localhost or *.localhost

You need to add the hostname to the new server.allowedHosts option. For example, if you are accessing the development server via http://foo.example.com:8080, you need to add foo.example.com to the server.allowedHosts option.

Using a plugin / framework that connects to the WebSocket server on their own from the browser

If you are using a plugin / framework, try upgrading to a newer version of Vite that fixes the vulnerability. If the WebSocket connection appears not to be working, the plugin / framework may have a code that connects to the WebSocket server on their own from the browser.

In that case, you can either:

  • fix the plugin / framework code to the make it compatible with the new version of Vite
  • set legacy.skipWebSocketTokenCheck: true to opt-out the fix for [2] while the plugin / framework is incompatible with the new version of Vite
    • When enabling this option, make sure that you are aware of the security implications described in the impact section of [2] above.

Mitigation without upgrading Vite

[1]: Permissive default CORS settings

Set server.cors to false or limit server.cors.origin to trusted origins.

[2]: Lack of validation on the Origin header for WebSocket connections

There aren't any mitigations for this.

[3]: Lack of validation on the Host header for HTTP requests

Use Chrome 94+ or use HTTPS for the development server.

Details

There are three causes that allowed malicious websites to send any requests to the development server:

[1]: Permissive default CORS settings

Vite sets the Access-Control-Allow-Origin header depending on server.cors option. The default value was true which sets Access-Control-Allow-Origin: *. This allows websites on any origin to fetch contents served on the development server.

Attack scenario:

  1. The attacker serves a malicious web page (http://malicious.example.com).
  2. The user accesses the malicious web page.
  3. The attacker sends a fetch('http://127.0.0.1:5173/main.js') request by JS in that malicious web page. This request is normally blocked by same-origin policy, but that's not the case for the reasons above.
  4. The attacker gets the content of http://127.0.0.1:5173/main.js.

[2]: Lack of validation on the Origin header for WebSocket connections

Vite starts a WebSocket server to handle HMR and other functionalities. This WebSocket server did not perform validation on the Origin header and was vulnerable to Cross-Site WebSocket Hijacking (CSWSH) attacks. With that attack, an attacker can read and write messages on the WebSocket connection. Vite only sends some information over the WebSocket connection (list of the file paths that changed, the file content where the errored happened, etc.), but plugins can send arbitrary messages and may include more sensitive information.

Attack scenario:

  1. The attacker serves a malicious web page (http://malicious.example.com).
  2. The user accesses the malicious web page.
  3. The attacker runs new WebSocket('http://127.0.0.1:5173', 'vite-hmr') by JS in that malicious web page.
  4. The user edits some files.
  5. Vite sends some HMR messages over WebSocket.
  6. The attacker gets the content of the HMR messages.

[3]: Lack of validation on the Host header for HTTP requests

Unless server.https is set, Vite starts the development server on HTTP. Non-HTTPS servers are vulnerable to DNS rebinding attacks without validation on the Host header. But Vite did not perform validation on the Host header. By exploiting this vulnerability, an attacker can send arbitrary requests to the development server bypassing the same-origin policy.

  1. The attacker serves a malicious web page that is served on HTTP (http://malicious.example.com:5173) (HTTPS won't work).
  2. The user accesses the malicious web page.
  3. The attacker changes the DNS to point to 127.0.0.1 (or other private addresses).
  4. The attacker sends a fetch('/main.js') request by JS in that malicious web page.
  5. The attacker gets the content of http://127.0.0.1:5173/main.js bypassing the same origin policy.

Impact

[1]: Permissive default CORS settings

Users with the default server.cors option may:

  • get the source code stolen by malicious websites
  • give the attacker access to functionalities that are not supposed to be exposed externally
    • Vite core does not have any functionality that causes changes somewhere else when receiving a request, but plugins may implement those functionalities and servers behind server.proxy may have those functionalities.

[2]: Lack of validation on the Origin header for WebSocket connections

All users may get the file paths of the files that changed and the file content where the error happened be stolen by malicious websites.

For users that is using a plugin that sends messages over WebSocket, that content may be stolen by malicious websites.

For users that is using a plugin that has a functionality that is triggered by messages over WebSocket, that functionality may be exploited by malicious websites.

[3]: Lack of validation on the Host header for HTTP requests

Users using HTTP for the development server and using a browser that is not Chrome 94+ may:

  • get the source code stolen by malicious websites
  • give the attacker access to functionalities that are not supposed to be exposed externally
    • Vite core does not have any functionality that causes changes somewhere else when receiving a request, but plugins may implement those functionalities and servers behind server.proxy may have those functionalities.

Chrome 94+ users are not affected for [3], because sending a request to a private network page from public non-HTTPS page is forbidden since Chrome 94.

Related Information

Safari has a bug that blocks requests to loopback addresses from HTTPS origins. This means when the user is using Safari and Vite is listening on lookback addresses, there's another condition of "the malicious web page is served on HTTP" to make [1] and [2] to work.

PoC

[2]: Lack of validation on the Origin header for WebSocket connections

  1. I used the react template which utilizes HMR functionality.
npm create vite@latest my-vue-app-react -- --template react
  1. Then on a malicious server, serve the following POC html:
<!doctype html>
<html lang="en">
    <head>
        <meta charset="utf-8" />
        <title>vite CSWSH</title>
    </head>
    <body>
        <div id="logs"></div>
        <script>
            const div = document.querySelectorAll('#logs')[0];
            const ws = new WebSocket('ws://localhost:5173','vite-hmr');
            ws.onmessage = event => {
                const logLine = document.createElement('p');
                logLine.innerHTML = event.data;
                div.append(logLine);
            };
        </script>
    </body>
</html>
  1. Kick off Vite
npm run dev
  1. Load the development server (open http://localhost:5173/) as well as the malicious page in the browser.
  2. Edit src/App.jsx file and intentionally place a syntax error
  3. Notice how the malicious page can view the websocket messages and a snippet of the source code is exposed

Here's a video demonstrating the POC:

vite-cswsh.mov

Release Notes

vitejs/vite (vite)

v7.0.4

Compare Source

Bug Fixes
  • allow resolving bare specifiers to relative paths for entries (#​20379) (324669c)
Build System

v7.0.3

Compare Source

Bug Fixes
Miscellaneous Chores
Code Refactoring
  • minor changes to reduce diff between normal Vite and rolldown-vite (#​20354) (2e8050e)

v7.0.2

Compare Source

Bug Fixes

v7.0.1

Compare Source

Bug Fixes
Miscellaneous Chores

v7.0.0

Compare Source

v6.3.5

Compare Source

v6.3.4

Compare Source

v6.3.3

Compare Source

v6.3.2

Compare Source

v6.3.1

Compare Source

v6.3.0

Compare Source

v6.2.7

Compare Source

Please refer to CHANGELOG.md for details.

v6.2.6

Compare Source

Please refer to CHANGELOG.md for details.

v6.2.5

Compare Source

Please refer to CHANGELOG.md for details.

v6.2.4

Compare Source

Please refer to CHANGELOG.md for details.

v6.2.3

Compare Source

Please refer to CHANGELOG.md for details.

v6.2.2

Compare Source

v6.2.1

Compare Source

v6.2.0

Compare Source

v6.1.6

Compare Source

Please refer to CHANGELOG.md for details.

v6.1.5

Compare Source

Please refer to CHANGELOG.md for details.

v6.1.4

Compare Source

Please refer to CHANGELOG.md for details.

v6.1.3

Compare Source

Please refer to CHANGELOG.md for details.

v6.1.2

Compare Source

Please refer to CHANGELOG.md for details.

v6.1.1

Compare Source

v6.1.0

Compare Source

Features
Fixes
Chore
Beta Changelogs
6.1.0-beta.2 (2025-02-04)

See 6.1.0-beta.2 changelog

6.1.0-beta.1 (2025-02-04)

See 6.1.0-beta.1 changelog

6.1.0-beta.0 (2025-01-24)

See 6.1.0-beta.0 changelog

v6.0.15

Compare Source

Please refer to CHANGELOG.md for details.

v6.0.14

Compare Source

Please refer to CHANGELOG.md for details.

v6.0.13

Compare Source

Please refer to CHANGELOG.md for details.

v6.0.12

Compare Source

Please refer to CHANGELOG.md for details.

v6.0.11

Compare Source


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot force-pushed the renovate/npm-vite-vulnerability branch from 0da8de8 to 9b48dfa Compare January 25, 2025 03:05
@renovate renovate bot changed the title chore(deps): update dependency vite to v4 [security] chore(deps): update dependency vite to v6 [security] Jan 25, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-vulnerability branch from 9b48dfa to d897cbd Compare January 26, 2025 06:48
@renovate renovate bot changed the title chore(deps): update dependency vite to v6 [security] chore(deps): update dependency vite to v4 [security] Jan 26, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-vulnerability branch from d897cbd to 1eafdda Compare January 31, 2025 07:58
@renovate renovate bot changed the title chore(deps): update dependency vite to v4 [security] chore(deps): update dependency vite to v6 [security] Jan 31, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-vulnerability branch from 1eafdda to 39d9273 Compare February 2, 2025 10:48
@renovate renovate bot changed the title chore(deps): update dependency vite to v6 [security] chore(deps): update dependency vite to v4 [security] Feb 2, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-vulnerability branch from 39d9273 to 07a1453 Compare February 11, 2025 03:26
@renovate renovate bot changed the title chore(deps): update dependency vite to v4 [security] chore(deps): update dependency vite to v6 [security] Feb 11, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-vulnerability branch from 07a1453 to 92c2556 Compare February 15, 2025 07:22
@renovate renovate bot changed the title chore(deps): update dependency vite to v6 [security] chore(deps): update dependency vite to v4 [security] Feb 15, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-vulnerability branch from 92c2556 to 1511c9e Compare March 6, 2025 03:54
@renovate renovate bot changed the title chore(deps): update dependency vite to v4 [security] chore(deps): update dependency vite to v6 [security] Mar 6, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-vulnerability branch from 1511c9e to a5ab4ca Compare March 8, 2025 04:04
@renovate renovate bot changed the title chore(deps): update dependency vite to v6 [security] chore(deps): update dependency vite to v4 [security] Mar 8, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-vulnerability branch from a5ab4ca to c8af7cb Compare March 13, 2025 07:48
@renovate renovate bot changed the title chore(deps): update dependency vite to v4 [security] chore(deps): update dependency vite to v6 [security] Mar 13, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-vulnerability branch from c8af7cb to ae3eb9c Compare March 15, 2025 12:11
@renovate renovate bot changed the title chore(deps): update dependency vite to v6 [security] chore(deps): update dependency vite to v4 [security] Mar 15, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-vulnerability branch from ae3eb9c to 82ffc9b Compare March 19, 2025 03:50
@renovate renovate bot changed the title chore(deps): update dependency vite to v4 [security] chore(deps): update dependency vite to v6 [security] Mar 19, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-vulnerability branch from 82ffc9b to 5580fbf Compare March 22, 2025 03:36
@renovate renovate bot changed the title chore(deps): update dependency vite to v6 [security] chore(deps): update dependency vite to v4 [security] Mar 22, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-vulnerability branch from 5580fbf to 124dd91 Compare April 1, 2025 23:44
@renovate renovate bot changed the title chore(deps): update dependency vite to v4 [security] chore(deps): update dependency vite to v6 [security] Apr 1, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-vulnerability branch from 124dd91 to 7489490 Compare April 3, 2025 23:49
@renovate renovate bot changed the title chore(deps): update dependency vite to v6 [security] chore(deps): update dependency vite to v4 [security] Apr 3, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-vulnerability branch from 7489490 to 8e4ea0a Compare April 12, 2025 03:45
@renovate renovate bot changed the title chore(deps): update dependency vite to v4 [security] chore(deps): update dependency vite to v6 [security] Apr 12, 2025
@renovate renovate bot changed the title chore(deps): update dependency vite to v4 [security] chore(deps): update dependency vite to v6 [security] Apr 26, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-vulnerability branch from c5f1e37 to 5b9d265 Compare April 27, 2025 08:09
@renovate renovate bot changed the title chore(deps): update dependency vite to v6 [security] chore(deps): update dependency vite to v4 [security] Apr 27, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-vulnerability branch from 5b9d265 to 3d64c63 Compare May 10, 2025 00:08
@renovate renovate bot changed the title chore(deps): update dependency vite to v4 [security] chore(deps): update dependency vite to v6 [security] May 10, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-vulnerability branch from 3d64c63 to fcd12bf Compare May 10, 2025 19:37
@renovate renovate bot changed the title chore(deps): update dependency vite to v6 [security] chore(deps): update dependency vite to v4 [security] May 10, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-vulnerability branch from fcd12bf to 771e5b5 Compare May 17, 2025 11:43
@renovate renovate bot changed the title chore(deps): update dependency vite to v4 [security] chore(deps): update dependency vite to v6 [security] May 17, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-vulnerability branch from 771e5b5 to aff1be9 Compare May 18, 2025 16:06
@renovate renovate bot changed the title chore(deps): update dependency vite to v6 [security] chore(deps): update dependency vite to v4 [security] May 18, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-vulnerability branch from aff1be9 to 3f83a73 Compare May 24, 2025 11:32
@renovate renovate bot changed the title chore(deps): update dependency vite to v4 [security] chore(deps): update dependency vite to v6 [security] May 24, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-vulnerability branch from 3f83a73 to b745a9f Compare May 25, 2025 19:59
@renovate renovate bot changed the title chore(deps): update dependency vite to v6 [security] chore(deps): update dependency vite to v4 [security] May 25, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-vulnerability branch from b745a9f to 032bcd5 Compare May 31, 2025 15:59
@renovate renovate bot changed the title chore(deps): update dependency vite to v4 [security] chore(deps): update dependency vite to v6 [security] May 31, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-vulnerability branch from 032bcd5 to 3353e7f Compare June 1, 2025 15:32
@renovate renovate bot changed the title chore(deps): update dependency vite to v6 [security] chore(deps): update dependency vite to v4 [security] Jun 1, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-vulnerability branch from 3353e7f to eabfa87 Compare June 6, 2025 15:58
@renovate renovate bot changed the title chore(deps): update dependency vite to v4 [security] chore(deps): update dependency vite to v6 [security] Jun 6, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-vulnerability branch from eabfa87 to 4d26b5a Compare June 8, 2025 10:06
@renovate renovate bot changed the title chore(deps): update dependency vite to v6 [security] chore(deps): update dependency vite to v4 [security] Jun 8, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-vulnerability branch from 4d26b5a to 2e2fd90 Compare June 22, 2025 19:55
@renovate renovate bot changed the title chore(deps): update dependency vite to v4 [security] chore(deps): update dependency vite to v6 [security] Jun 22, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-vulnerability branch from 2e2fd90 to ad06ad3 Compare June 29, 2025 23:53
@renovate renovate bot changed the title chore(deps): update dependency vite to v6 [security] chore(deps): update dependency vite to v4 [security] Jun 29, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-vulnerability branch from ad06ad3 to e6781b8 Compare July 12, 2025 08:11
@renovate renovate bot changed the title chore(deps): update dependency vite to v4 [security] chore(deps): update dependency vite to v7 [security] Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants